-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Allow CrosshairTool and HoverTool to trigger from axes
#14124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3263821 to
c9ac8a5
Compare
CrosshairTool to work on axesCrosshairTool and HoverTool to work on axes
Contributor
Author
|
I added similar support to Screencast.from.2024-10-26.10-40-53.webm |
789f48b to
c4a1ecb
Compare
bryevdv
approved these changes
Oct 28, 2024
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor comments
c4a1ecb to
6f27fc6
Compare
CrosshairTool and HoverTool to work on axesCrosshairTool and HoverTool to trigger from axes
6f27fc6 to
58761ab
Compare
58761ab to
749db65
Compare
Contributor
Author
|
Test failures are unrelated and reported in #14128. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.from.2024-10-26.01-04-07.webm
fixes #14122