8000 only make CORS origin header explicit if origin is known by pmeier · Pull Request #13999 · bokeh/bokeh · GitHub
[go: up one dir, main page]
Skip to content

only make CORS origin header explicit if origin is known #13999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryevdv merged 1 commit into from
Jul 26, 2024
Merged

only make CORS origin header explicit if origin is known #13999

bryevdv merged 1 commit into from
Jul 26, 2024

Conversation

@pmeier
Copy link
Contributor
@pmeier pmeier commented Jul 26, 2024

cc @hakan-77

@pmeier pmeier mentioned this pull request Jul 26, 2024
Closed
@codecov
Copy link
codecov bot commented Jul 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (branch-3.6@6404785). Learn more about missing BASE report.

Additional details and impacted files 
@@              Coverage Diff              @@
##             branch-3.6   #13999   +/-   ##
=============================================
  Coverage              ?   93.14%           
=============================================
  Files                 ?      281           
  Lines                 ?    19822           
  Branches              ?        0           
=============================================
  Hits                  ?    18463           
  Misses                ?     1359           
  Partials              ?        0

@bryevdv
Copy link
Member
bryevdv commented Jul 26, 2024

Thanks @pmeier

@bryevdv bryevdv merged commit 18ee70b into bokeh:branch-3.6 Jul 26, 2024
@bryevdv
Copy link
Member
bryevdv commented Jul 26, 2024

@mattpap I added NEEDS BACK PORT on the assumption there were will probably be a 3.5.2 at some point

@mattpap mattpap added this to the 3.6 milestone Jul 27, 2024
@mattpap
Copy link
Contributor
mattpap commented Jul 27, 2024

Sure, I already created 3.5.2 milestone. I expect to release patch versions more often from now on.

@jmargus
Copy link
jmargus commented Aug 7, 2024

Would love to get 3.5.2 with this one, breaks the embedding for us at the moment.

@hakan-77
Copy link
hakan-77 commented Aug 8, 2024

@jmargus same here, we had to downgrade.

mattpap pushed a commit that referenced this pull request Aug 9, 2024
@pmeier @mattpap
only make CORS origin header explicit if origin is known (#13999)
415f4af
@mattpap mattpap mentioned this pull request Aug 9, 2024
Merged
12 tasks
@mattpap mattpap modified the milestones: 3.6, 3.5.2 Aug 22, 2024
@bryevdv
Copy link
Member
bryevdv commented Aug 23, 2024

@jmargus @hakan-77 this fix is now available in 3.5.2

Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
@pmeier @Chiemezuo
only make CORS origin header explicit if origin is known (bokeh#13999)
48e5091
@hakan-77
Copy link
hakan-77 commented Aug 30, 2024

@bryevdv it works. Thanks!

@github-actions
Copy link
github-actions bot commented Dec 11, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bryevdv bryevdv bryevdv approved these changes

Assignees

No one assigned

Labels

status: accepted

Projects

None yet

Milestone

3.5.2

Development

Successfully merging this pull request may close these issues.

[BUG] If Origin is missing from cookie, autoload js handler fails with Tornado KeyError: 'Origin'

5 participants

@pmeier @bryevdv @mattpap @jmargus @hakan-77
0