8000 avoid Sphinx ThemeError and set Sphinx to a minimum of 7.1.0 by mosc9575 · Pull Request #13560 · bokeh/bokeh · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@mosc9575
Copy link
Contributor
@mosc9575 mosc9575 commented Nov 30, 2023

This change solves a problem in the build of the docs if Sphinx 7.2.0 or newer is used. This also changes the minimum version of SPhinx to 7.1.0

@bryevdv I am not sure about the check you were asking for. I created the docs on my local machine and the pages are looking good to me. But I think this is not enough.

@mosc9575 mosc9575 changed the title avoid_Sphinx ThemeError and set Sphinx to a minimum of 7.1.0 avoid Sphinx ThemeError and set Sphinx to a minimum of 7.1.0 Nov 30, 2023
@codecov
Copy link
codecov bot commented Nov 30, 2023

Codecov Report

Merging #13560 (aedb999) into branch-3.4 (2555a4f) will decrease coverage by 0.01%.
Report is 4 commits behind head on bran 8000 ch-3.4.
The diff coverage is n/a.

Additional details and impacted files
@@              Coverage Diff               @@
##           branch-3.4   #13560      +/-   ##
==============================================
- Coverage       92.57%   92.57%   -0.01%     
==============================================
  Files             322      322              
  Lines           20460    20461       +1     
==============================================
  Hits            18941    18941              
- Misses           1519     1520       +1     

@bryevdv
Copy link
Member
bryevdv commented Nov 30, 2023

I am not sure about the check you were asking for.

@mosc9575 if you look in the browsers "dev tools" there should be a network tab where you can see all the resources that are loaded for a page. Based on the comment in the issue, we'd expect to see custom.css getting loaded with some unique hash in an HTTP argument that Sphinx has added. Let me know if that makes sense.

@mosc9575
Copy link
Contributor Author
mosc9575 commented Dec 1, 2023

css_version
grafik

LGTM.

Copy link
Member
@bryevdv bryevdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mosc9575 !

@bryevdv bryevdv added this to the 3.4 milestone Dec 2, 2023
@bryevdv bryevdv merged commit 05a7ecb into bokeh:branch-3.4 Dec 2, 2023
@mosc9575 mosc9575 deleted the 13548_avoid_Sphinx_ThemeError branch December 21, 2023 20:05
@mosc9575 mosc9575 mentioned this pull request Jan 8, 2024
22 tasks
mattpap added a commit that referenced this pull request Jan 8, 2024
* Add a regression test for issue #8890 (#13572)

* Don't register keyup twice in `AutocompleteInput` (#13577)

* Don't register keyup twice in AutocompleteInput

* Pin pytest-asyncio to version 0.21.1

* Link sub-coordinate and context dependent ranges in RangesUpdate (#13603)

* Fix support for global/local imported stylesheets (#13559)

* Compatibility with Chromium 110

* Robustify unit tests involving browser output (#13602)

* Multiple density estimate plot (#13527)

* added sample data

* created density plot

* added gallery images and json

* sorted import order

* clarified plot description

* refactored plotting file

* changed tick formatting style

* deleted unused import

* deleted whitespace

* additional file refactoring

* pyramid example plot (#13596)

* added sample data

* created plot and added plot  description

* added gallery image

* minor edits

* modified plot title

* added bar labels to plot

* removed whitespace

* post-review

* changed color palette

* added plot image

* added extra tick markers

* Remove unnecessary arcTo calls in round_rect (#13627)

* Update license and copyright statements to 2024 (#13630)

* Use `ruff` to ban `typing_extensions` at the top-level (#13633)

* Upgrade to ruff 0.1.11

* Enable TID rules and disable TID252 for now

* Ban `typing_extensions` module at the top-level

* Remove test_no_typing_extensions_common

* Import `typing_extensions` under `TYPE_CHECKING` in `*.pyi`

* Correctly handle transforms in SVG arcTo (#13640)

* ban PIL and other imports with ruff (#13639)

* fix indentation in sphinx extentions (#13549)

* fix indentation in property mixins (#13514)

* fix indentation of default strings with dedent from textwrap

* add missing words in property_mixins.py

* fix indentation in tools.py

* remove dedent block and introduce ALPHA_DEFAULT_HELP and COLOR_DEFAULT_HELP

* change order of imports

* Restored broken API links (#13528)

* restored broken API links

* modified broken API path

* Allow newer tornado and pandas in test-minimal-deps (#13635)

* Add release notes

* Update switcher.json

* avoid_Sphinx ThemeError and set Sphinx to a minimum of 7.1.0 (#13560)

* fix some sphinx warnings (#13609)

* fix some sphinx warnings

* don't make the first line bold

* fix warnings caused by sampledata (#13613)

* add forensic glass and emissions to sampledata.rst (#13615)

---------

Co-authored-by: Azaya <99359668+Azaya89@users.noreply.github.com>
Co-authored-by: Ian Thomas <ianthomas23@gmail.com>
Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>
Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com>
@mattpap mattpap modified the milestones: 3.4, 3.3.3 Jan 8, 2024
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Sphinx 7.2.6 raises ThemeError

3 participants

0