8000 Example metadata for gallery examples · Pull Request #11490 · bokeh/bokeh · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@ghost
Copy link
@ghost ghost commented Aug 10, 2021

Adding ReST docstrings to examples in gallery.

@ghost ghost requested a review from bryevdv August 10, 2021 14:58
8000
@mattpap mattpap added this to the 2.4 milestone Aug 10, 2021
@bokeh bokeh deleted a comment from lgtm-com bot Aug 10, 2021
@bryevdv
Copy link
Member
bryevdv commented Aug 10, 2021

cc @tcmetzger Would love your input. @hyles-lineata and I worked to come up with this basic organizational system, this PR is intended as a final draft before rolling out similar additions to all the gallery examples.

Note the "keywords" portion is still a bit vague. Eventually I'd like to tie in sphinx's cross-referencing capabilities somehow, but for now it's just some hand-curated terms

@tcmetzger
Copy link
Member

This looks great and will be very good to have in the gallery!

Just some thoughts on the displayed text:
image

I'd suggest capitalizing each new line, i.e. "Sampledata:", "Bokeh API:", etc. We should at least make sure to consistently capitalize "Bokeh" (i.e. the second element in the list). I would also suggest to change "references:" to something like "User guide references:" or just "User guide:" - otherwise this might be confused with a link to the reference guide.

Eventually, it would also be nice to make all keywords clickable, so that clicking on "scatter" would get me to a list of all examples with the "scatter" keyword, for example.

@bryevdv
Copy link
Member
bryevdv commented Aug 11, 2021

to something like "User guide references:" or just "User guide:" - otherwise this might be confused with a link to the reference guide.

I'd like to keep it more general, e.g. links could be to user guide, or reference guide, tutorial notebooks, etc. I'd also like to keep the LHS short/concise. Maybe just "Links" ? "Related" ? "More info" ?

Eventually, it would also be nice to make all keywords clickable, so that clicking on "scatter" would get me to a list of all examples with the "scatter" keyword, for example.

That might be fairly non-trivial given that this a nominally formed as a verbatim code block

Edit n/m I thought you were talking about all the API calls in the code. Yes that kind of cross referencing is exactly what I'd like.

@tcmetzger
Copy link
Member

@bryevdv That sounds good - my preference would be "More info" but I think they would all work!

@ghost
Copy link
Author
ghost commented Aug 13, 2021

Selection_101

Headings capitalized, pipes removed!

@mattpap
Copy link
Contributor
mattpap commented Aug 13, 2021

Merge branch 'main' of https://github.com/hyles-lineata/bokeh

This is suspicious, main branch was last updated in February. This should have been branch-2.4.

@ghost
Copy link
Author
ghost commented Aug 13, 2021

You're right; I screwed up there. Trying to do too many things at once. Will roll back.

@lgtm-com
Copy link
lgtm-com bot commented Aug 25, 2021

This pull request introduces 9 alerts when merging 2590030 into 23bf76b - view on LGTM.com

new alerts:

  • 9 for Unused import

@bryevdv bryevdv changed the title WIP: docstrings for gallery examples Example metadata for gallery examples Aug 25, 2021
@bryevdv
Copy link
Member
bryevdv commented Aug 25, 2021

LGTM I think I cleared the minor codebase issues editing in the GH web UI. If so I'll merge when green so that the new directive is available for others to use!

bryevdv added a commit that referenced this pull request Dec 13, 2021
* first round of docstrings added

* removed some file outputs

* pipes removed; subject headings capitalized

* added bokeh-example-metadata directive

* removing unused imports

* trailing lines

* isort

Co-authored-by: carolyn <carolyn@bokeh.org>
Co-authored-by: Bryan Van de Ven <bryan@bokeh.org>
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Enhanced docstrings for gallery entries

3 participants

0