8000 Update blynklib.py by Delilovic · Pull Request #39 · blynkkk/lib-python · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on May 7, 2025. It is now read-only.

Update blynklib.py #39

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Update blynklib.py #39

merged 2 commits into from
Nov 20, 2020

Conversation

Delilovic
Copy link
Contributor

The hardware disconnects from the server when it reaches the value 65535 (see the log file below), this change fixed the issue, no more disconnects.

14:51:34.477 TRACE- Incoming HardwareMessage{id=65526, command=Hardware, body='vw^@1^@25.7'}
14:51:34.482 TRACE- Incoming HardwareMessage{id=65527, command=Hardware, body='vw^@2^@40'}
14:51:35.350 TRACE- Incoming id=65528, command=Ping, body=''
14:51:35.513 TRACE- Incoming HardwareMessage{id=65529, command=Hardware, body='vw^@14^@255'}
14:51:35.539 TRACE- Incoming HardwareMessage{id=65530, command=Hardware, body='vw^@1^@25.7'}
14:51:35.543 TRACE- Incoming HardwareMessage{id=65531, command=Hardware, body='vw^@2^@40'}
14:51:36.573 TRACE- Incoming HardwareMessage{id=65532, command=Hardware, body='vw^@14^@255'}
14:51:36.597 TRACE- Incoming HardwareMessage{id=65533, command=Hardware, body='vw^@1^@25.7'}
14:51:36.601 TRACE- Incoming HardwareMessage{id=65534, command=Hardware, body='vw^@2^@40'}
14:51:37.629 TRACE- Incoming HardwareMessage{id=65535, command=Hardware, body='vw^@14^@255'}
14:51:37.654 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.7'}
14:51:37.659 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:37.875 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@4^@0'}
14:51:38.696 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@14^@255'}
14:51:38.718 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.7'}
14:51:38.723 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:39.751 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@14^@255'}
14:51:39.776 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.6'}
14:51:39.781 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:40.811 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@14^@255'}
14:51:40.836 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.6'}
14:51:40.842 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:41.871 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@14^@255'}
14:51:41.896 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.6'}
14:51:41.902 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:42.930 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@14^@255'}
14:51:42.956 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.6'}
14:51:42.961 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:43.990 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@14^@255'}
14:51:44.015 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.6'}
14:51:44.019 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:45.046 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@14^@255'}
14:51:45.068 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.6'}
14:51:45.073 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:45.435 TRACE- Incoming id=0, command=Ping, body=''
14:51:45.494 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@0^@server disconnected'}
14:51:45.505 TRACE- Hardware channel disconnect for UserKey{email='email@email.com', appName='Blynk'}, dashId 363038412, deviceId 0, token 34ANGpngMJdq1Vzc6MzjsqB37K8nmZOU.
14:51:45.507 TRACE- Changing device status. DeviceId 0, dashId 363038412
14:51:46.618 TRACE- Blynk hardware plain protocol connection detected.
14:51:46.623 TRACE- Incoming LoginMessage{id=4, command=Login, body='34ANGpngMJdq1Vzc6MzjsqB37K8nmZOU'}
14:51:46.627 DEBUG- completeLogin. [id: 0x42d222c5, L:/127.0.1.1:8080 - R:/127.0.0.1:32794]
14:51:46.639 TRACE- Connected device id 0, dash id 363038412
14:51:46.644 INFO - email@email.com hardware joined.
14:51:46.645 TRACE- Incoming id=5, command=Internal, body='ver^@0.2.6^@buff-in^@1024^@h-beat^@10^@dev^@python'
14:51:46.649 TRACE- Info command. heartbeat interval 10
14:51:46.768 DEBUG-

Request Defaul 8000 tFullHttpRequest(decodeResult: success, version: HTTP/1.1, content: UnpooledSlicedByteBuf(freed))
POST /fcm/send HTTP/1.1
Authorization: key=AAAAucxWLNg:APA91bHqxju865u6rpENgdsDM0HAK6pfYr0iCpcgkzmKrLWpH-8ljrTps5467tx0Ok0ZrpmB_vUIRRVW2hjutrGgT1btT_d6WpU0RVsdfzzMSeHPwm2yXd37Lyi05H3C7Fz-7ZimilslN
content-type: application/json; charset=utf-8
content-length: 262
host: fcm.googleapis.com
accept: /

Response DefaultHttpResponse(decodeResult: success, version: HTTP/1.1)
HTTP/1.1 200 OK
Content-Type: application/json; charset=UTF-8
Date: Wed, 11 Nov 2020 13:51:46 GMT
Expires: Wed, 11 Nov 2020 13:51:46 GMT
Cache-Control: private, max-age=0
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
Content-Security-Policy: frame-ancestors 'self'
X-XSS-Protection: 1; mode=block
Server: GSE
Alt-Svc: h3-Q050=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-T050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
Accept-Ranges: none
Vary: Accept-Encoding
Transfer-Encoding: chunked

14:51:47.620 TRACE- Incoming HardwareMessage{id=6, command=Hardware, body='vw^@14^@255'}
14:51:47.642 TRACE- Incoming HardwareMessage{id=7, command=Hardware, body='vw^@1^@25.6'}
14:51:47.645 TRACE- Incoming HardwareMessage{id=8, command=Hardware, body='vw^@2^@40'}

@Delilovic
Update blynklib.py
d187962 
The hardware disconnects from the server when it reaches the value 65535 (see the log file below), this change fixed the issue, no more disconnects.

 14:51:34.477 TRACE- Incoming HardwareMessage{id=65526, command=Hardware, body='vw^@1^@25.7'}
14:51:34.482 TRACE- Incoming HardwareMessage{id=65527, command=Hardware, body='vw^@2^@40'}
14:51:35.350 TRACE- Incoming id=65528, command=Ping, body=''
14:51:35.513 TRACE- Incoming HardwareMessage{id=65529, command=Hardware, body='vw^@14^@255'}
14:51:35.539 TRACE- Incoming HardwareMessage{id=65530, command=Hardware, body='vw^@1^@25.7'}
14:51:35.543 TRACE- Incoming HardwareMessage{id=65531, command=Hardware, body='vw^@2^@40'}
14:51:36.573 TRACE- Incoming HardwareMessage{id=65532, command=Hardware, body='vw^@14^@255'}
14:51:36.597 TRACE- Incoming HardwareMessage{id=65533, command=Hardware, body='vw^@1^@25.7'}
14:51:36.601 TRACE- Incoming HardwareMessage{id=65534, command=Hardware, body='vw^@2^@40'}
14:51:37.629 TRACE- Incoming HardwareMessage{id=65535, command=Hardware, body='vw^@14^@255'}
14:51:37.654 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.7'}
14:51:37.659 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:37.875 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@4^@0'}
14:51:38.696 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@14^@255'}
14:51:38.718 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.7'}
14:51:38.723 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:39.751 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@14^@255'}
14:51:39.776 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.6'}
14:51:39.781 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:40.811 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@14^@255'}
14:51:40.836 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.6'}
14:51:40.842 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:41.871 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@14^@255'}
14:51:41.896 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.6'}
14:51:41.902 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:42.930 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@14^@255'}
14:51:42.956 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.6'}
14:51:42.961 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:43.990 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@14^@255'}
14:51:44.015 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.6'}
14:51:44.019 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:45.046 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@14^@255'}
14:51:45.068 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@1^@25.6'}
14:51:45.073 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@2^@40'}
14:51:45.435 TRACE- Incoming id=0, command=Ping, body=''
14:51:45.494 TRACE- Incoming HardwareMessage{id=0, command=Hardware, body='vw^@0^@server disconnected'}
14:51:45.505 TRACE- Hardware channel disconnect for UserKey{email='email@email.com', appName='Blynk'}, dashId 363038412, deviceId 0, token 34ANGpngMJdq1Vzc6MzjsqB37K8nmZOU.
14:51:45.507 TRACE- Changing device status. DeviceId 0, dashId 363038412
14:51:46.618 TRACE- Blynk hardware plain protoc
8000
ol connection detected.
14:51:46.623 TRACE- Incoming LoginMessage{id=4, command=Login, body='34ANGpngMJdq1Vzc6MzjsqB37K8nmZOU'}
14:51:46.627 DEBUG- completeLogin. [id: 0x42d222c5, L:/127.0.1.1:8080 - R:/127.0.0.1:32794]
14:51:46.639 TRACE- Connected device id 0, dash id 363038412
14:51:46.644 INFO - email@email.com hardware joined.
14:51:46.645 TRACE- Incoming id=5, command=Internal, body='ver^@0.2.6^@buff-in^@1024^@h-beat^@10^@dev^@python'
14:51:46.649 TRACE- Info command. heartbeat interval 10
14:51:46.768 DEBUG-

Request DefaultFullHttpRequest(decodeResult: success, version: HTTP/1.1, content: UnpooledSlicedByteBuf(freed))
POST /fcm/send HTTP/1.1
Authorization: key=AAAAucxWLNg:APA91bHqxju865u6rpENgdsDM0HAK6pfYr0iCpcgkzmKrLWpH-8ljrTps5467tx0Ok0ZrpmB_vUIRRVW2hjutrGgT1btT_d6WpU0RVsdfzzMSeHPwm2yXd37Lyi05H3C7Fz-7ZimilslN
content-type: application/json; charset=utf-8
content-length: 262
host: fcm.googleapis.com
accept: */*

Response DefaultHttpResponse(decodeResult: success, version: HTTP/1.1)
HTTP/1.1 200 OK
Content-Type: application/json; charset=UTF-8
Date: Wed, 11 Nov 2020 13:51:46 GMT
Expires: Wed, 11 Nov 2020 13:51:46 GMT
Cache-Control: private, max-age=0
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
Content-Security-Policy: frame-ancestors 'self'
X-XSS-Protection: 1; mode=block
Server: GSE
Alt-Svc: h3-Q050=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-T050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
Accept-Ranges: none
Vary: Accept-Encoding
Transfer-Encoding: chunked

14:51:47.620 TRACE- Incoming HardwareMessage{id=6, command=Hardware, body='vw^@14^@255'}
14:51:47.642 TRACE- Incoming HardwareMessage{id=7, command=Hardware, body='vw^@1^@25.6'}
14:51:47.645 TRACE- Incoming HardwareMessage{id=8, command=Hardware, body='vw^@2^@40'}
@antohaUa
Copy link
Collaborator

Hi! Tnx for found case. The most interesting thing that micropython lib already have this logic.
Just to be aligned with micropython lib I suggest leave existing code with change 0 ->1

self._msg_id += 1
return self._msg_id if self._msg_id <= 0xFFFF else 1

@Delilovic
Update blynklib.py
6436589 
Keeping the fix consistent with the MicroPython implementation (see #39 (comment))
antohaUa
antohaUa approved these changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator
@antohaUa antohaUa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@antohaUa antohaUa merged commit b2cc4f5 into blynkkk:master Nov 20, 2020
@Delilovic Delilovic deleted the patch-1 branch June 30, 2021 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antohaUa antohaUa antohaUa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Delilovic @antohaUa
0