This repository was archived by the owner on May 7, 2025. It is now read-only.
Substract timestamps using ticks_diff() to account for wrap around #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the utime documentation, ticks_diff() should be used to compare timestamps. They say the wrap around is implementation specific but on forums I see people saying it's about 298 hours/12 days which at least is the case for me on the tinypico. In this specific case, the wrap around means the deltas will be small negative numbers which in turn will make is_server_alive() return True for days without sending anymore pings to the server. We will soon after get disconnected and the application will pretty much stay forever in that state.
antohaUa
approved these changes
Aug 19, 2020
|
Thx for this found case. |
1 similar comment
|
Thx for this found case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the utime documentation, ticks_diff() should be used to compare
timestamps. They say the wrap around is implementation specific but on
forums I see people saying it's about 298 hours/12 days which at least
is the case for me on the tinypico.
In this specific case, the wrap around means the deltas will be small
negative numbers which in turn will make is_server_alive() return True
for days without sending anymore pings to the server. We will soon after
get disconnected and the application will pretty much stay forever in
that state.