[PM-29599] create proration preview endpoint #6858
Conversation
|
Claude finished @kdenney's task in 1m 48s —— View job Code Review: PM-29599 Create Proration Preview EndpointSummaryThis PR implements a new endpoint ( Review Status: ApprovedThis PR is well-implemented with comprehensive test coverage and follows established billing patterns in the codebase. Strengths
Breaking Changes (Documented)The PR description correctly documents these breaking changes with a frontend coordination ticket (PM-29600):
Minor Observations (Non-blocking)
|
|
Fixed Issues (3)Great job! The following issues were fixed in this Pull Request
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6858 +/- ##
==========================================
- Coverage 59.90% 56.09% -3.82%
==========================================
Files 1966 1968 +2
Lines 86883 86997 +114
Branches 7741 7739 -2
==========================================
- Hits 52046 48797 -3249
- Misses 32954 36397 +3443
+ Partials 1883 1803 -80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
also using the correct proration behavior and making the upgrade flow start a trial
There was a problem hiding this comment.
Clean ✅. Thanks for the in depth tests and the additions to the upgrade logic and parameters. 🦸♂️
| planType, | ||
| billingAddress); | ||
|
|
||
| return Handle(result.Map(pair => new { pair.Tax, pair.Total, pair.Credit })); |
There was a problem hiding this comment.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-29599
📔 Objective
Implements a new endpoint to preview the prorated cost when upgrading from a Premium individual subscription to an Organization plan. Also refactors billing preview endpoints by renaming TaxController to PreviewInvoiceController.
Notable Changes:
Controller Refactoring
New Endpoint
Updated Upgrade Endpoint
Commands
Breaking Changes
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes