E5F0 qa: Make wallet_multiwallet.py Windows-compatible by hodlinator · Pull Request #34418 · bitcoin/bitcoin · GitHub
[go: up one dir, main page]
Skip to content

qa: Make wallet_multiwallet.py Windows-compatible #34418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hodlinator wants to merge 10 commits into
base: master
Choose a base branch
from
+201 −138
Open

qa: Make wallet_multiwallet.py Windows-compatible #34418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4d0b3b8
refactor(qa): Remove unused option
hodlinator Jan 26, 2026
7f429ee
scripted-diff: self.nodes[0] => node
hodlinator Jan 24, 2026
32e2eff
refactor(qa): Lift out functions to outer scopes
hodlinator Jan 26, 2026
0cabd3c
move-only(qa): Move wallet creation check down to others
hodlinator Jan 26, 2026
6a652d9
refactor(qa): Break apart ginormous run_test()
hodlinator Jan 27, 2026
2c4c4f0
qa: Check for platform-independent part of error message
hodlinator Jan 26, 2026
3f552ae
qa: Test scanning errors individually
hodlinator Jan 27, 2026
a36aae2
qa: Disable parts of the test when running under Windows or root
hodlinator Jan 27, 2026
abf373e
ci: Enable `wallet_multiwallet.py` in "Windows, test cross-built" job
hebasto Apr 2, 2025
596752a
qa: Avoid duplicating output in case the diff is the same
hodlinator Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,9 +506,7 @@ jobs:
py -3 -m pip install pyzmq
py -3 test/functional/test_runner.py --jobs $NUMBER_OF_PROCESSORS --quiet --tmpdirprefix="$RUNNER_TEMP" --combinedlogslen=99999999 --timeout-factor=$TEST_RUNNER_TIMEOUT_FACTOR $TEST_RUNNER_EXTRA \
`# feature_unsupported_utxo_db.py fails on Windows because of emojis in the test data directory.` \
--exclude feature_unsupported_utxo_db.py \
`# See https://github.com/bitcoin/bitcoin/issues/31409.` \
--exclude wallet_multiwallet.py
--exclude feature_unsupported_utxo_db.py
# Run feature_unsupported_utxo_db sequentially in ASCII-only tmp dir,
# because it is excluded above due to lack of UTF-8 support in the
# ancient release.
Expand Down
5 changes: 4 additions & 1 deletion test/functional/test_framework/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,10 @@ def summarise_dict_differences(thing1, thing2):
def assert_equal(thing1, thing2, *args):
if thing1 != thing2 and not args and isinstance(thing1, dict) and isinstance(thing2, dict):
d1,d2 = summarise_dict_differences(thing1, thing2)
raise AssertionError("not(%s == %s)\n in particular not(%s == %s)" % (thing1, thing2, d1, d2))
if d1 != thing1 or d2 != thing2:
raise AssertionError(f"not({thing1!s} == {thing2!s})\n in particular not({d1!s} == {d2!s})")
else:
raise AssertionError(f"not({thing1!s} == {thing2!s})")
if thing1 != thing2 or any(thing1 != arg for arg in args):
raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))

Expand Down
Loading
Loading
0