qa: Make wallet_multiwallet.py Windows-compatible #34418
+201
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last use was removed in 0d32d66.
-BEGIN VERIFY SCRIPT- sed --in-place 's/self\.nodes\[0\]/node/g; s/node \= node/node \= self\.nodes\[0\]/' ./test/functional/wallet_multiwallet.py -END VERIFY SCRIPT-
This prepares for later breaking apart of run_test(). Note that the "wallet" lambda was renamed to "get_wallet" since otherwise the Python interpreter emitted: "UnboundLocalError: cannot access local variable 'wallet' where it is not associated with a value"
Makes the functions broken out from run_test() in the next commit more cohesive.
On Windows one gets different exception messages depending on whether running a native build or cross build.
This change ensures that each condition potentially triggering the "Error while scanning" log message is tested independently, avoiding false positives. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
test_scanning_sub_dir(): - Remove try/finally - we don't need to clean up after a failed test (done in this commit to maintain indentation). Regarding symlinks: bitcoin#31410 (comment) Co-authored-by: Ava Chow <github@achow101.com>
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34418. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
wallet_multiwallet.py Windows-compatible
hebasto
reviewed
Jan 27, 2026
Member
There was a problem hiding this comment.
Concept ACK.
Thanks for taking this over!
w0xlt
reviewed
Jan 27, 2026
Contributor
There was a problem hiding this comment.
Approach ACK. I’ll review it more closely soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main parts:
wallet_multiwallet.py#31410.wallet_multiwallet.py#31410 (comment).Also:
run_test()into smaller test functions.assert_equal()output for dicts.Fixes #31409.