wallet: skip APS when no partial spend exists #34405
Open
+64
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34405. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
b686262 to
d6edd15
Compare
APS runs a second coin selection to fully spend UTXOs sharing a scriptPubKey. Currently runs unconditionally, even when the first selection has no partial spend and APS cannot help. Detect partial spends by comparing selected vs available UTXO counts per scriptPubKey inside CreateTransactionInternal, reusing available_coins. Add has_partial_spend to CreatedTransactionResult. Skip APS if false. Update interface_usdt_coinselection test to expect APS to be skipped when no partial spend exists. Add new test that creates a partial spend scenario so the full APS tracepoint flow is verified. Fixes bitcoin#25150
d6edd15 to
53de94f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25150
APS (Avoid Partial Spends) runs a second coin selection pass to fully spend
UTXOs sharing a scriptPubKey. This currently runs unconditionally, even when
the first selection has no partial spend. Running APS unnecessarily wastes
computation and can produce a worse result when there was nothing to fix.
Detect partial spends by comparing selected vs available UTXO counts per
scriptPubKey, reusing available_coins. Skip APS if none found.
Test updated to create partial spend scenarios so tracepoints fire.
Supersedes #34362 which was corrupted by a shallow clone force-push.