8000 [MNT] tests/mds: Fix tests w.r.t. current dev scikit-learn by ales-erjavec · Pull Request #7061 · biolab/orange3 · GitHub
[go: up one dir, main page]
Skip to content

[MNT] tests/mds: Fix tests w.r.t. current dev scikit-learn #7061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

[MNT] tests/mds: Fix tests w.r.t. current dev scikit-learn #7061

merged 1 commit into from
Apr 4, 2025

Conversation

ales-erjavec
Copy link
Contributor
Issue

Current Scientific Python nightly tests fail

Description of changes

Relax test tolerance due to upstream scikit-learn implementation change (probably modified stopping condition in scikit-learn/scikit-learn#30514)

Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec
tests/mds: Fix tests w.r.t current dev scikit-learn
435c7f6 
Relax test tolerance due to changed stopping condition in upstream
scikit-learn implementation
@codecov Codecov
Copy link
codecov bot commented Apr 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.61%. Comparing base (c338b38) to head (435c7f6).
Report is 74 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7061      +/-   ##
==========================================
- Coverage   88.62%   88.61%   -0.01%     
==========================================
  Files         332      332              
  Lines       73366    73366              
==========================================
- Hits        65019    65015       -4     
- Misses       8347     8351       +4
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janezd janezd merged commit f606f13 into biolab:master Apr 4, 2025
30 checks passed
@markotoplak markotoplak mentioned this pull request Jun 9, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ales-erjavec @janezd
0