E5DD Allow scikit-learn 1.3 by markotoplak · Pull Request #6585 · biolab/orange3 · GitHub
[go: up one dir, main page]
Skip to content

Allow scikit-learn 1.3 #6585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PrimozGodec merged 6 commits into from
Sep 29, 2023
Merged

Allow scikit-learn 1.3 #6585

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c06e132
Allow scikit-learn 1.3
markotoplak Sep 21, 2023
4e01d47
SklLearner.support_weights: support for decorated fit
markotoplak Sep 22, 2023
e95c041
add tests for Learners' supports_weights
markotoplak Sep 25, 2023
3822d1b
Limit scikit-learn to <1.4 due to unsolved deprecations
markotoplak Sep 25, 2023
e9b2a16
deprecate SklLearner.support_weights
noahnovsak Sep 26, 2023
6db3de3
time bomb
markotoplak Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
SklLearner.support_weights: support for decorated fit
  • Loading branch information
@markotoplak
markotoplak committed Sep 25, 2023
commit 4e01d479ee2dd8d41c5879f7613b0287e262977b
6 changes: 5 additions & 1 deletion Orange/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,11 @@ def fit(self, X, Y, W=None):
def supports_weights(self):
"""Indicates whether this learner supports weighted instances.
"""
return 'sample_weight' in self.__wraps__.fit.__code__.co_varnames
varnames = self.__wraps__.fit.__code__.co_varnames
# scikit-learn often uses decorators on fit()
if hasattr(self.__wraps__.fit, "__wrapped__"):
varnames = varnames + self.__wraps__.fit.__wrapped__.__code__.co_varnames
return 'sample_weight' in varnames

def __getattr__(self, item):
try:
Expand Down
0