8000 Improve VSCode color theme support by MillironX · Pull Request #59 · bioSyntax/bioSyntax · GitHub
[go: up one dir, main page]

Skip to content

Improve VSCode color theme support#59

Merged
Ebedthan merged 5 commits intobioSyntax:masterfrom
MillironX:master
Jul 29, 2021
Merged

Improve VSCode color theme support#59
Ebedthan merged 5 commits intobioSyntax:masterfrom
MillironX:master

Conversation

@MillironX
Copy link
Contributor
@MillironX MillironX commented Jul 28, 2021

This is a direct fix for #50.

  1. It allows for more graceful fallback to a user's desired color theme by exposing a new setting BioSyntax.nonBioTheme. The extension will revert the editor's color theme to match that setting upon switching away from a BioSyntax-compatible document.
  2. Users may opt out of using the extension's color theme entirely by setting BioSyntax.autoSwitchTheme to false, while retaining the background coloring provided by the extension's scripts.

A known issue with these updates is that VSCode must be restarted for any settings changes to be reflected.

In order to compile the extension on my machine, several dependencies and structural elements have also been changed. These potentially fix #49.

Visual Studio code extensions use different dependencies than when this
extension was first created. All of these changes simply bring the
extension up-to-date with current practices.
@Ebedthan
Copy link
Contributor

Great @MillironX , I'll review the PR tonight. Thanks again!

@Ebedthan Ebedthan self-assigned this Jul 29, 2021
@Ebedthan Ebedthan self-requested a review July 29, 2021 10:07
Copy link
Contributor
@Ebedthan Ebedthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be fine! Great first contribution @MillironX .

@Ebedthan Ebedthan merged commit 83d5b38 into bioSyntax:master Jul 29, 2021
@Ebedthan Ebedthan linked an issue Jul 29, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to disable automatic theme switching in VSCode Update the VSCode extension?

2 participants

0