8000 Fix/node12 + add device caps by sebakerckhof · Pull Request #48 · bellbind/node-v4l2camera · GitHub
[go: up one dir, main page]
Skip to content

Fix/node12 + add device caps#48

Open
sebakerckhof wants to merge 9 commits intobellbind:masterfrom
sebakerckhof:fix/node12
Open

Fix/node12 + add device caps#48
sebakerckhof wants to merge 9 commits intobellbind:masterfrom
sebakerckhof:fix/node12

Conversation

@sebakerckhof
Copy link
@sebakerckhof sebakerckhof commented Sep 4, 2019

This adds device capability listings (useful to filter meta capture devices in debian 10 based systems)

  • fixes compilation for node 10+ (currently works on latest 12 release)

@sebakerckhof sebakerckhof mentioned this pull request Sep 4, 2019
Open
@Crisfole
Copy link
Crisfole commented Nov 1, 2019

This looks like a dead repo, but in case it's not: I can verify this fix successfully fixes the install process. Currently testing the actual camera component itself

@uullrich
Copy link
uullrich commented Jan 4, 2020

It works perfect! With this fix there are no more problems during the build process.

@theflyingape
Copy link
theflyingape commented Dec 19, 2022 •
edited
Loading

Looks like there's an issue now with Python 3.11: ValueError: invalid mode: 'rU' while trying to load binding.gyp
The U file mode was removed in Python 3.11 because it had no effect so the U can merely be removed.

File "node/v12.22.12/lib/node_modules/npm/node_modules/node-gyp/gyp/pylib/gyp/input.py", line 234, in LoadOneBuildFile
    build_file_contents = open(build_file_path, 'rU').read()
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: invalid mode: 'rU' while trying to load binding.gyp

Removing the U works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sebakerckhof @Crisfole @uullrich @theflyingape @sigoden
0