8000 Add missing methods for OpenPGP v6 API by vanitasvitae · Pull Request #2105 · bcgit/bc-java · GitHub
[go: up one dir, main page]
Skip to content

Add missing methods for OpenPGP v6 API #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add missing methods for OpenPGP v6 API #2105

wants to merge 8 commits into from

Conversation

vanitasvitae
Copy link
Contributor

This PR contains some missing methods that were not yet merged in #1911

The PR was created by adding in missing functionality that the current v6 branch of PGPainless depends on, so it is not complete, but adds enough to make PGPainless compile and allow the tests to pass.

Hope this helps :)

@ligefeiBouncycastle ligefeiBouncycastle self-requested a review June 17, 2025 02:19
@vanitasvitae
Copy link
Contributor Author

Some background on c931f24 :
I'd like to keep this a (functional) interface if possible. The factory methods can be moved into another class (as I did -> Util), but keeping the class an interface enables implementers to simply provide a lambda expression when a KeyPairGeneratorCallback object is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligefeiBouncycastle ligefeiBouncycastle Awaiting requested review from ligefeiBouncycastle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vanitasvitae
0