8000 High-Level API #0: Preparations for high-level OpenPGP Key Generator API by vanitasvitae · Pull Request #1926 · bcgit/bc-java · GitHub
[go: up one dir, main page]
Skip to content

High-Level API #0: Preparations for high-level OpenPGP Key Generator API #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

High-Level API #0: Preparations for high-level OpenPGP Key Generator API #1926

wants to merge 12 commits into from

Conversation

vanitasvitae
Copy link
Contributor

This is part 1 of the split-up patch adding a high-level key generator API.
This one is focussed on changes required in /openpgp/, /openpgp/operator/ and /bcpg/.

It also contains the fix from #1882 (the test will be included in the second PR).

@vanitasvitae vanitasvitae mentioned this pull request Nov 28, 2024
Closed
@vanitasvitae vanitasvitae mentioned this pull request Dec 3, 2024
Open
@vanitasvitae vanitasvitae changed the title Preparations for high-level OpenPGP Key Generator API High-Level API #0: Preparations for high-level OpenPGP Key Generator API Dec 3, 2024
@vanitasvitae
Copy link
Contributor Author

Some context for 32fc48b :
The Stateless OpenPGP Protocol allows implementations to emit the plain session key that was used to encrypt a message during the encryption process1. This feature can be used by implementations to retain access to the plaintext of ab encrypted message without the need to have access to decryption secret key material2.

The best way I found to add support for session-key extraction in a backwards-compatible manner was by using a callback. Let me know what you think of this feature.

In 15ae18e I also exposed the encrypted data packet object. This is needed in order to emit, which encryption method (SEIPDv1, SEIPDv2, legacy SED, LibrePGP OED) was used to encrypt the message with.

hubot pushed a commit that referenced this pull request Dec 12, 2024
Update from #1926
74b0afc
@vanitasvitae
PGPSignatureSubpacketGenerator: Add generics to the packet list
8000
1f8031e
@vanitasvitae
PGPSignatureSubpacketVector: Add generics to the subpacket list
bad96c1
@vanitasvitae
PGPKeyRingGenerator: Various improvements
af77347 
* Rename masterKey -> primaryKey
* Add generics to list structures
* sanitize primary and subkeys
* properly instantiate signature generators by passing key version
@vanitasvitae
Add PublicKeyUtils
03261c0 
This class contains methods for checking properties of public key algorithms
@vanitasvitae
Add missing javadoc
c849ef1
@vanitasvitae
Introcude superclass AEADSecretKeyEncryptorBuilder
31bea53 
Both the BcAEADSecretKeyEncryptorBuilder and JcaAEADSecretKeyEncryptorBuilder did not share
a common super type. This patch added AEADSecretKeyEncryptorBuilder for this purpose.
@vanitasvitae
Operator changes
e76db13
@vanitasvitae
KeyIdentifier changes
bbc24de
@vanitasvitae
PGPEncryptedDataGenerator: Allow extraction of session-key
0b6c1d6
@vanitasvitae
PGPEncryptedDataList: Expose encrypted data packet
81d47ab
@vanitasvitae
PGPSignature: Add isRevocation, isHardRevocation methods
0ffd502
@vanitasvitae
Fix typo in isNotNull error message
9b96a7d
@ligefeiBouncycastle
Copy link
Collaborator

There are some classes that are still under review and will be merged into the main branch later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligefeiBouncycastle ligefeiBouncycastle Awaiting requested review from ligefeiBouncycastle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanitasvitae @ligefeiBouncycastle
0