Vega Custom Toolbar #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forman
requested changes
Nov 5, 2024
|
|
||
| export interface DashiDropdownProps extends Omit<DropdownState, "type"> { | ||
| onPropertyChange: PropertyChangeHandler; | ||
| panelIndex: number; |
Member
There was a problem hiding this comment.
The term panel does not exist is the API, the lib part. This is relevant fort the demo only.
Also, I don't see why this is needed in every component now.
Member
|
@b-yogesh I close this PR, I create an issue instead that specifies what is needed. |
Collaborator
Author
Sure! Let's do that. When we start working on it, we use this PR as a starting point to get some ideas (if needed) |
4 tasks
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.