8000 Switch rails-rspec src-dir by lackita · Pull Request #1781 · bbatsov/projectile · GitHub
[go: up one dir, main page]

Skip to content

Switch rails-rspec src-dir#1781

Merged
bbatsov merged 1 commit intobbatsov:masterfrom
lackita:master
Jun 26, 2022
Merged

Switch rails-rspec src-dir#1781
bbatsov merged 1 commit intobbatsov:masterfrom
lackita:master

Conversation

@lackita
Copy link
Contributor
@lackita lackita commented Jun 18, 2022

Rails puts most of its source files under app rather than lib. This
updates the src-dir to allow easy switching between source and test
files in this case.


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

@bbatsov
Copy link
Owner
bbatsov commented Jun 23, 2022

Makes sense. I guess we should do the same for rails-minitest as well.

@lackita
Copy link
Contributor Author
lackita commented Jun 26, 2022

Good call, I'll try to change that tomorrow

Rails puts most of its source files under app rather than lib. This
updates the src-dir to allow easy switching between source and test
files in this case.
@lackita
Copy link
Contributor Author
lackita commented Jun 26, 2022

Alright, I think that's all set now. Let me know if you want me to change anything else.

@bbatsov bbatsov merged commit 8f2e1ea into bbatsov:master Jun 26, 2022
@bbatsov
Copy link
Owner
bbatsov commented Jun 26, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0