Add project detection for Debian packaging directories#1657
Merged
bbatsov merged 1 commit intobbatsov:masterfrom May 24, 2021
Merged
Add project detection for Debian packaging directories#1657bbatsov merged 1 commit intobbatsov:masterfrom
bbatsov merged 1 commit intobbatsov:masterfrom
Conversation
This adds project detection for unpacked Debian source packages. We detect
this by checking for the presence of a debian/control file even though
technically we should probably check for all of
debian/{rules,contro,changelog}. I found documenting this too cumbersome so
I went with just the control file.
In Debian there's two main (lightweight) ways of building packages:
dpkg-buildpackage and debuild. The latter is pretty much just a wrapper for
the former that also runs static checks across the resulting package.
Developers usually use debuild so that's what we use here. The -uc -us
options we hardcode are extremely common. They disable codesigning which
you'd usually not want to do for a simple developmnet build since it can
always be done using debsign before uploading the package.
Since tests usually run as part of the Debian package build and there isn't
a unified way to run just the tests we don't add a :test command.
Technically there's autopkgtest for running special 'as installed' tests
after the package build, but this requires setting up some virtualisation
drivers beforehand so it doesn't make much sense here either.
bbatsov
reviewed
Mar 9, 2021
| :compile "bazel build" | ||
| :test "bazel test" | ||
| :run "bazel run") | ||
| (projectile-register-project-type 'debian "debian/control" |
Owner
There was a problem hiding this comment.
Something like debian-pkg would be a more descriptive name.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds project detection for unpacked Debian source packages. We detect
this type by the presence of a debian/control even though technically we
should probably check for all of debian/{rules,contro,changelog}. I found
documenting this too cumbersome so I went with just the control file.
In Debian there's two main (lightweight) ways of building packages:
dpkg-buildpackage and debuild. The latter is pretty much just a wrapper for
the former that also runs static checks across the resulting package.
Developers usually use debuild so that's what we use here. The -uc -us
options we hardcode are extremely common. They disable codesigning which
you'd usually not want to do for a simple developmnet build since it can
always be done using debsign before uploading the package.
Since tests usually run as part of the Debian package build and there isn't
a unified way to run just the tests we don't add a :test command.
Technically there's autopkgtest for running special 'as installed' tests
after the package build, but this requires setting up some virtualisation
drivers beforehand so it doesn't make much sense here either.
eldev test)M-x checkdocwarnings