E53A Make sure projectile-files-via-ext-command returns files not errors by maurelio1234 · Pull Request #1438 · bbatsov/projectile · GitHub
[go: up one dir, main page]
Skip to content

Make sure projectile-files-via-ext-command returns files not errors#1438

Merged
bbatsov merged 1 commit intobbatsov:masterfrom
maurelio1234:master
Dec 2, 2020
Merged

Make sure projectile-files-via-ext-command returns files not errors#1438
bbatsov merged 1 commit intobbatsov:masterfrom
maurelio1234:master

Conversation

@maurelio1234
Copy link
Contributor
@maurelio1234 maurelio1234 commented Aug 10, 2019 •
edited
Loading

If a command fails, it may return an error message like:
fatal: No url found for submodule path 'XXX' in .gitmodules.

It just filters out error messages to avoid the calling code to try to
use it as a file name.

Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

@maurelio1234 maurelio1234 force-pushed the master branch 2 times, most recently from 3940e58 to 3f3f7ae Compare August 10, 2019 10:27
bbatsov
bbatsov reviewed Sep 4, 2019
View reviewed changes
Make sure projectile-files-via-ext-command returns files not errors
a6b9821 
If command files fails, it may return an error message like:
`fatal: No url found for submodule path 'XXX' in .gitmodules`.

Just ignores error messages to avoid the calling code trying to
use it as a file name.
@immerrr
Copy link
Contributor
immerrr commented Nov 18, 2020

Got hit by this, and was going to propose a PR, but found that there is one already.

@bbatsov any chance on getting this merged?

@bbatsov bbatsov merged commit 351e0c3 into bbatsov:master Dec 2, 2020
@bbatsov
Copy link
Owner
bbatsov commented Dec 2, 2020

Seems I forgot about it, but it looks in good shape. Thanks, @maurelio1234!

928A
bbatsov added a commit that referenced this pull request Dec 2, 2020
@bbatsov
Add a changelog entry for #1438
42f8101
This was referenced Dec 2, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbatsov bbatsov bbatsov left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maurelio1234 @immerrr @bbatsov
0