Enhance go project detection by referring to go.mod file#1418
Merged
bbatsov merged 3 commits intobbatsov:masterfrom Jun 4, 2019
Merged
Enhance go project detection by referring to go.mod file#1418bbatsov merged 3 commits intobbatsov:masterfrom
bbatsov merged 3 commits intobbatsov:masterfrom
Conversation
bbatsov
reviewed
Jun 1, 2019
added 3 commits
June 3, 2019 17:08
This file is present in many (but not all) go projects. When go 1.13 comes out later this year, the go.mod file might become a sufficient check for a go project but today that is not the case.
9748d99 to
c3ec56d
Compare
Contributor
Author
|
Thanks for the review. Feedback and merge conflicts have been addressed. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue encountered when working in a go project that doesn't have any
.gofiles at the root. The fix is to check for ago.modfile at the root of the project, avoiding a recursive descent of the project. Thego.modfile is new-ish and will be present in projects that are using Go modules. The file will be present in all (or almost all) Go projects when Go 1.13 is released later this year.I didn't add any tests, but this is the fix I applied to my local install of projectile and it worked great.
Feel free to remove or tweak my Changelog entry, this change may not be big enough to warrant documentation.
make test)M-x checkdocwarnings