ignored-*-p: Match against regular expressions#1260
Merged
bbatsov merged 9 commits intobbatsov:masterfrom Jul 28, 2018
Merged
Conversation
Buffers are created by other packages that appear on projectile's buffer lists, but they always have some variation that makes impossible including all possible name cases, thus regular expressions come handy for this sort of cases. This commit allows `*-ignored-*-p` functions to work with regular expressions.
The function was incorrectly defined, causing to fail on tests. The correct thing to do is to call `projectile-ignored-directories` which returns a sequence.
A new one has to be created as I mess with my fork and the branch
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffers are created by other packages that appear on projectile's buffer lists, but they always have
some variation that makes impossible including all possible name cases, thus regular expressions
come handy for this sort of cases. This commit allows
*-ignored-*-pfunctions to work with regularexpressions.
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
make test)M-x checkdocwarningsThanks!