Use pretty aspect class names in errors #28444
Open
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the default `toString()` implementation was used, printing the full class name and hash code.
There was a problem hiding this comment.
Code Review
This pull request improves error messages by using pretty aspect class names in TopLevelAspectsKey.getDescription(). The change is good, but I've suggested a small improvement to use Java 8 streams instead of Guava's Lists.transform for consistency with the existing codebase.
Comment on lines
+379
to
+381
| Lists.transform(topLevelAspectsClasses, AspectClass::getName), | ||
| topLevelAspectsParameters, | ||
| targetLabel); |
There was a problem hiding this comment.
While Lists.transform works, using Java 8 streams would be more consistent with other parts of this file (e.g., lines 252 and 304 which use stream()...collect(toImmutableList())). This would also make the new import of com.google.common.collect.Lists unnecessary.
Suggested change
| Lists.transform(topLevelAspectsClasses, AspectClass::getName), | |
| topLevelAspectsParameters, | |
| targetLabel); | |
| topLevelAspectsClasses.stream().map(AspectClass::getName).collect(toImmutableList()), | |
| topLevelAspectsParameters, | |
| targetLabel); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the default
toString()implementation was used, printing the full class name and hash code.