8000 Introduce artifacts macro by groodt · Pull Request #989 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

Introduce artifacts macro #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Introduce artifacts macro #989

wants to merge 10 commits into from

Conversation

groodt
Copy link
Collaborator
@groodt groodt commented Jan 14, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@aignas aignas mentioned this pull request Jan 18, 2023
Closed
12 tasks
aignas added a commit to aignas/rules_python that referenced this pull request Jan 27, 2023
@aignas
feat!: generate user friendly aliases for everyone
bddd80f 
This is related to bazel-contrib#814 as it is bringing user-friendly alias generation
and it is doing this in a breaking way for the `bzlmod` users who are
not using the `requirement` macro. The labels that they use will change
from `@@repo//:{name}_pkg` to `@@repo//{name}`.

I am intentionally leaving the requirement macros in the
requirements.bzl unchanged as bazel-contrib#989 might change the approach again.

Since these aliases can be used by bzlmod and non-bzlmod users, we can
then support the same generated `gazelle_python.yaml` for both bzlmod
and non-bzlmod users.
@github-actions
Copy link

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

@github-actions github-actions bot added the Can Close? Will close in 30 days if there is no new activity label Jul 16, 2023
@github-actions
Copy link

This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

@github-actions github-actions bot closed this Aug 15, 2023
@aignas aignas deleted the groodt-artifacts-macro branch October 17, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev will be requested when the pull request is marked ready for review rickeylev is a code owner

@aignas aignas Awaiting requested review from aignas aignas will be requested when the pull request is marked ready for review aignas is a code owner

Assignees
No one assigned
Labels
Can Close? Will close in 30 days if there is no new activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@groodt
0