10000 fix: windows `*.lib` interface in `python_headers` by lukasoyen · Pull Request #976 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

fix: windows *.lib interface in python_headers #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2023
Merged

fix: windows *.lib interface in python_headers #976

merged 1 commit into from
Jan 24, 2023

Conversation

lukasoyen
Copy link
Contributor
@lukasoyen lukasoyen commented Jan 5, 2023 •
edited by f0rmiga
Loading

A user might use python_headers to build an extension module that does not itself pull in the python shared library. On Windows, this needs to expose the *.lib interface file to compile correctly.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Currently a user on Windows can not compile a native extension module and build against python_headers.

Issue Number: N/A

What is the new behavior?

It is fixed.

Does this PR introduce a breaking change?

  • Yes
  • No

@lukasoyen lukasoyen requested a review from f0rmiga as a code owner January 5, 2023 16:48
@google-cla
Copy link
google-cla bot commented Jan 5, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lukasoyen lukasoyen force-pushed the add-interface-file-in-python-headers branch from 4552278 to 8dd7edd Compare January 6, 2023 08:54
f0rmiga
f0rmiga approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member
@f0rmiga f0rmiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the vendored files as per https://buildkite.com/bazel/rules-python-python/builds/3953#0185864a-040b-45b6-8b06-6bb8f054b316, please?

@lukasoyen
fix: add the windows *.lib interface file to the python_headers l…
a7a15ce 
…ibrary

A user might use `python_headers` to build an extension module that does
not itself pull in the python shared library. On Windows, this needs to
expose the `*.lib` interface file to compile correctly.
@lukasoyen lukasoyen force-pushed the add-interface-file-in-python-headers branch from 8dd7edd to a7a15ce Compare January 24, 2023 10:31
@lukasoyen
Copy link
Contributor Author

I am not sure how that failure relates to this PR. But I have rebased on main. Let's see what happens.

bazel run //:vendor_requirements does nothing with bazel 6.0.0.

@f0rmiga f0rmiga changed the title fix: add the windows *.lib interface file to the python_headers l… fix: windows *.lib interface in python_headers Jan 24, 2023
@f0rmiga f0rmiga merged commit ba45af0 into bazel-contrib:main Jan 24, 2023
@lukasoyen lukasoyen deleted the add-interface-file-in-python-headers branch January 24, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f0rmiga f0rmiga f0rmiga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasoyen @f0rmiga
0