8000 Fix CI after bazel 6.0.0 by groodt · Pull Request #938 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

Fix CI after bazel 6.0.0 #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2022
Merged

Fix CI after bazel 6.0.0 #938

merged 2 commits into from
Dec 21, 2022

Conversation

groodt
Copy link
Collaborator
@groodt groodt commented Dec 21, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

CI is failing due to a diff_test failure. See https://buildkite.com/bazel/rules-python-python/builds/3802#01853209-eaee-4f51-b2e9-6eeb9308cb5c
The failure is caused by a small change in the formatting of labels.

What is the new behavior?

The incompatible_unambiguous_label_stringification flag was flipped in bazelbuild/bazel#16196, this changes the behaviour when labels are stringified.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@groodt groodt requested a review from rickeylev as a code owner December 21, 2022 11:13
@groodt groodt requested a review from f0rmiga December 21, 2022 11:17
@groodt groodt requested a review from alexeagle December 21, 2022 21:26
@groodt groodt mentioned this pull request Dec 21, 2022
Merged
chrislovecnm
chrislovecnm reviewed Dec 21, 2022
View reviewed changes
Copy link
Contributor
@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT - can we get this merged?

alexeagle
alexeagle approved these changes Dec 21, 2022
View reviewed changes
version.bzl
@@ -17,7 +17,7 @@
# against.
# This version should be updated together with the version of Bazel
# in .bazelversion.
BAZEL_VERSION = "5.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess not in this PR, but we really should address that TODO down in line 28, or we'll very soon break rules_python for Bazel 5.x users by accident.

@groodt groodt merged commit 8331522 into main Dec 21, 2022
@f0rmiga f0rmiga deleted the groodt-fix-ci branch December 24, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@chrislovecnm chrislovecnm chrislovecnm approved these changes

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

@f0rmiga f0rmiga Awaiting requested review from f0rmiga

Assignees

@alexeagle alexeagle

@f0rmiga f0rmiga

@rickeylev rickeylev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@groodt @alexeagle @chrislovecnm @f0rmiga @rickeylev
0