fix: embed stamped version in py_wheel METADATA #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattoberle
commented
Dec 19, 2022
This seems unrelated to the bazel-contrib#845 issue fix. CI wants `requirements.bzl` to list `@//:requirements.txt` not `//:requirements.txt`?
Co-authored-by: Matt Oberle <matt.r.oberle@gmail.com>
f0rmiga
approved these changes
Dec 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #845
Prior to
rules_python==0.14.0thedist-info/METADATAfile built bypy_wheelresolved stamped data.This can be confirmed by doing the following:
git checkout 0.13.0 git cherry-pick 921ad79 bazel test //examples/wheel/...Where
921ad79is the commit from this PR that adds the test for the resolved version.Beginning with
0.14.0, version is incorrectly set.What is the new behavior?
This PR restores the previous behavior by writing the
Version:inwheelmaker.py.One side effect is that the order of the
METADATAfile is modified.Version:was previously afterName:. NowVersion:is the final key before the "description".Does this PR introduce a breaking change?