8000 Remove unused code by groodt · Pull Request #933 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

Remove unused code #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2022
Merged

Remove unused code #933

merged 1 commit into from
Dec 19, 2022

Conversation

groodt
Copy link
Collaborator
@groodt groodt commented Dec 19, 2022 •
edited
Loading

Removes unused code. The code that is generating requirements.bzl is parse_requirements_to_bzl.py

Aside: I do think these generated helper functions in the repository rule could probably be replaced with simpler macros similar to the macro included in rules_jvm_external. See: https://github.com/bazelbuild/rules_jvm_external#artifact-helper-macro

@groodt groodt requested review from rickeylev, hrfuller and f0rmiga and removed request for hrfuller December 19, 2022 10:09
@groodt groodt marked this pull request as ready for review December 19, 2022 10:09
@groodt groodt requested a review from hrfuller as a code owner December 19, 2022 10:09
@groodt groodt removed the request for review from hrfuller December 19, 2022 10:10
@groodt groodt changed the title Remove unused Remove unused code Dec 19, 2022
hrfuller
hrfuller approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor
@hrfuller hrfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@groodt groodt merged commit 222ec4b into bazel-contrib:main Dec 19, 2022
Sign up 7830 for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrfuller hrfuller hrfuller approved these changes

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

@f0rmiga f0rmiga Awaiting requested review from f0rmiga

Assignees

@f0rmiga f0rmiga

@rickeylev rickeylev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@groodt @hrfuller @f0rmiga @rickeylev
0