8000 Escape characters in the wheel filename. by pstradomski · Pull Request #518 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

Escape characters in the wheel filename. #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2021
Merged

Escape characters in the wheel filename. #518

merged 2 commits into from
Aug 31, 2021

Conversation

pstradomski
Copy link
Contributor

Escape characters in the wheel filename.

Note the implementation is buggy, it replaces non-ascii (unicode) letters in the filename. Unfortunately, starlark isalnum function returns wrong result here, and regexp support is not available yet.

Fixes #517.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #517

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Aug 29, 2021
@alexeagle
Copy link
Contributor

Thanks!

What's the implication of the wrong handling for unicode alpha characters? Is that frequent?
IIUC that's not a newly introduced regression in this PR, as those wheels would have had wrong names before as well.

alexeagle
alexeagle approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor
@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexeagle alexeagle merged commit 9a10fdb into bazel-contrib:main Aug 31, 2021
@pstradomski
Copy link
Contributor Author
pstradomski commented Aug 31, 2021 via email

@vonschultz vonschultz mentioned this pull request Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@andyscott andyscott Awaiting requested review from andyscott

@brandjon brandjon Awaiting requested review from brandjon

@lberki lberki Awaiting requested review from lberki

@thundergolfer thundergolfer Awaiting requested review from thundergolfer

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect wheel filename for distribution names with hyphen
2 participants
@pstradomski @alexeagle
0