8000 Migrate from bazelbuild/skydoc to bazelbuild/stardoc by thundergolfer · Pull Request #484 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

Migrate from bazelbuild/skydoc to bazelbuild/stardoc #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 8, 2021
Merged

Migrate from bazelbuild/skydoc to bazelbuild/stardoc #484

merged 4 commits into from
Jun 8, 2021

Conversation

thundergolfer
Copy link

Using https://github.com/bazelbuild/stardoc/releases/tag/0.4.0

First release of Stardoc under the new repository location bazelbuild/stardoc. Please use this repository for future Stardoc releases instead of its old location.

Begins addressing #255. We can close that issue once we've removed needless <code> tags in docs, and instead use backticks.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

@thundergolfer thundergolfer requested a review from andyscott as a code owner June 8, 2021 12:54
@google-cla google-cla bot added the cla: yes label Jun 8, 2021
@thundergolfer thundergolfer requested a review from alexeagle June 8, 2021 12:54
alexeagle
alexeagle approved these changes Jun 8, 2021
View reviewed changes
update_docs.sh
@@ -21,3 +21,4 @@ bazel build //docs/...
cp bazel-bin/docs/python.md docs/
cp bazel-bin/docs/pip.md docs/
cp bazel-bin/docs/whl.md docs/
cp bazel-bin/docs/packaging.md docs/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after this lands, I'll send you a PR making this tested on CI like I have in other rules

@thundergolfer thundergolfer merged commit d95e89f into master Jun 8, 2021
@thundergolfer thundergolfer deleted the jonathon--update-stardoc-ext-repo-dep-jun2021 branch June 9, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@andyscott andyscott Awaiting requested review from andyscott

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thundergolfer @alexeagle
0