8000 Added packaging docs by UebelAndre · Pull Request #480 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

Added packaging docs #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 8, 2021
Merged

Added packaging docs #480

merged 3 commits into from
Jun 8, 2021

Conversation

UebelAndre
Copy link
Contributor
@UebelAndre UebelAndre commented Jun 3, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently there is no documentation for the python/packaging.bzl module making it's existence pretty invisible

Issue Number: N/A

What is the new behavior?

This adds a stardoc target and updated documentation such that it can be rendered at https://docs.aspect.dev/rules_python

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Jun 3, 2021
@UebelAndre UebelAndre marked this pull request as ready for review June 3, 2021 15:59
thundergolfer
thundergolfer approved these changes Jun 8, 2021
View reviewed changes
Copy link
@thundergolfer thundergolfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

@thundergolfer thundergolfer merged commit eaed210 into bazel-contrib:master Jun 8, 2021
@UebelAndre UebelAndre deleted the docs branch June 8, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thundergolfer thundergolfer thundergolfer approved these changes

@andyscott andyscott Awaiting requested review from andyscott

@brandjon brandjon Awaiting requested review from brandjon

@lberki lberki Awaiting requested review from lberki

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UebelAndre @thundergolfer
0