8000 Ignore global pip config files for pip-compile by keith · Pull Request #473 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

Ignore global pip config files for pip-compile #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2021
Merged

Ignore global pip config files for pip-compile #473

merged 2 commits into from
Jun 8, 2021

Conversation

keith
Copy link
Member
@keith keith commented May 20, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

This makes sure global pip config files don't leak into your pip-compile, similar to #389

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

If a user has a global pip config file, say with extra URLs, those will get included in the output from pip-compile, but it will not be reproducible for others.

What is the new behavior?

Those files are completely ignored.

Does this PR introduce a breaking change?

  • Yes
  • No
  • Kinda

If folks were relying on this, it could cause issues. This leaves the escape hatch of people being able to manually specify the PIP_CONFIG_FILE in their env to set it explicitly.

@keith keith requested review from brandjon and lberki as code owners May 20, 2021 19:03
keith
keith commented May 20, 2021
View reviewed changes
@google-cla google-cla bot added the cla: yes label May 20, 2021
@thundergolfer thundergolfer self-requested a review May 21, 2021 06:03
@keith keith force-pushed the ks/ignore-global-pip-config-files-for-pip-compile branch from a75dfa2 to 33c5f1b Compare May 28, 2021 17:11
@keith keith force-pushed the ks/ignore-global-pip-config-files-for-pip-compile branch from 33c5f1b to cb29a31 Compare May 28, 2021 17:12
@thundergolfer thundergolfer merged commit 4b114a4 into bazel-contrib:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plule plule plule left review comments

@thundergolfer thundergolfer thundergolfer approved these changes

@brandjon brandjon Awaiting requested review from brandjon

@lberki lberki Awaiting requested review from lberki

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keith @plule @thundergolfer
0