Merge rules python external #348
Conversation
…-from-rules-pip
…namespace_pkgs module where it really belongs
|
Note, buildkite failure is because it treats linter warnings as fatal. My recommendation is to make the new subdirectory lint-clean in a followup PR, but we could add a commit here to make it green if maintainers prefer. |
|
@googlebot I consent. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Just enough to get CI green for now
7fb6153 to
3a4de2a
Compare
|
gergelyfabian has signed the CLA as he authored #315 |
|
@googlebot I consent. |
Not sure if it makes it any easier if everyone signs the CLA or not, but maybe mentioning them will help put this on their radar. cc |
|
(CLA done) |
1 similar comment
|
(CLA done) |
|
(CLA done)
JoshuaCrestone <notifications@github.com> ezt írta (időpont: 2020. aug.
21., P 2:57):
… (CLA done)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#348 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJGRRKGMMVOHPEUPUGSY2DSBXA6XANCNFSM4QE7XHAQ>
.
|
|
@googlebot I consent. |
4 similar comments
|
@googlebot I consent. |
|
@googlebot I consent. |
|
@googlebot I consent. |
|
@googlebot I consent. |
|
@chickenandpork could you also reply with the |
|
@googlebot I consent. |
|
I'm not sure if this PR needs some manual re-kick to recheck CLAs. If you want to bisect the issue or carve off some delta by splitting this PR or pulling aside us minimal-impacters, @-tag me, happy to come back and consent to another merge |
|
As long as we have documented the consent, we aren't required to make the check turn green. This is ready to merge I think, just requires an admin to click the button |
|
|
Was squashed and we lost merge history This reverts commit 0d23d57.
This is the beginning of making that the canonical way to get dependencies, replacing the pip features in this repo.
Our plan is in multiple steps: