8000 Merge rules python external by alexeagle · Pull Request #348 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]

Skip to content

Merge rules python external #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexeagle
Copy link
Contributor
@alexeagle alexeagle commented Aug 19, 2020

This is the beginning of making that the canonical way to get dependencies, replacing the pip features in this repo.

Our plan is in multiple steps:

  • (this PR) bring in the repo to a subdirectory, preserving git history and contributors
  • clean up the code, remove mypy, get it functional in that subdirectory
  • add an example/integration test proving that it works
  • cut a patch release and get some users to test it out
  • communicate our deprecation plan to rules_python users
  • BIG SWITCH: move the rules_python_external implementation to the root, make a legacy/ directory for current impl
  • fill in any missing docstrings and include new rules in stardoc
  • cut a breaking release (a minor, since semver starting with 0. states that minors are breaking)
  • help users switch over
  • in a later breaking release, actually remove the old implementation

dillon-giacoppo and others added 30 commits November 1, 2019 17:38
…namespace_pkgs module where it really belongs
@alexeagle
Copy link
Contributor Author

Note, buildkite failure is because it treats linter warnings as fatal. My recommendation is to make the new subdirectory lint-clean in a followup PR, but we could add a commit here to make it green if maintainers prefer.

@thundergolfer
Copy link

@googlebot I consent.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Just enough to get CI green for now
@alexeagle alexeagle force-pushed the merge_rules_python_external branch from 7fb6153 to 3a4de2a Compare August 20, 2020 03:48
@alexeagle
Copy link
Contributor Author

gergelyfabian has signed the CLA as he authored #315
remaining authors of commits merged here have only one commit each on rules_python_external, mostly trivial changes.

@groodt
Copy link
Collaborator
groodt commented Aug 20, 2020

@googlebot I consent.

@groodt
Copy link
Collaborator
groodt commented Aug 20, 2020

remaining authors of commits merged here have only one commit each on rules_python_external, mostly trivial changes.

Not sure if it makes it any easier if everyone signs the CLA or not, but maybe mentioning them will help put this on their radar.

cc
@spietras
@gergelyfabian
@kevingessner
@chickenandpork
@benjamin-fleischmann
@JoshuaCrestone

@chickenandpork
Copy link
Contributor

(CLA done)

1 similar comment
@JoshuaCrestone
Copy link
Contributor

(CLA done)

@gergelyfabian
Copy link
Contributor
gergelyfabian commented Aug 21, 2020 via email

@gergelyfabian
Copy link
Contributor

@googlebot I consent.

4 similar comments
@spietras
Copy link
Contributor

@googlebot I consent.

@benjamin-fleischmann
Copy link
Contributor

@googlebot I consent.

@kevingessner
Copy link
Contributor

@googlebot I consent.

@JoshuaCrestone
Copy link
Contributor

@googlebot I consent.

@alexeagle
Copy link
Contributor Author

@chickenandpork could you also reply with the @googlebot I consent. text? I think this is the last one causing CLA status to be red

@chickenandpork
Copy link
Contributor

@googlebot I consent.

@chickenandpork
Copy link
Contributor

I'm not sure if this PR needs some manual re-kick to recheck CLAs. If you want to bisect the issue or carve off some delta by splitting this PR or pulling aside us minimal-impacters, @-tag me, happy to come back and consent to another merge

@alexeagle
Copy link
Contributor Author

As long as we have documented the consent, we aren't required to make the check turn green. This is ready to merge I think, just requires an admin to click the button

@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@thundergolfer thundergolfer merged commit 0d23d57 into bazel-contrib:master Aug 25, 2020
@alexeagle alexeagle deleted the merge_rules_python_external branch August 25, 2020 14:28
alexeagle pushed a commit to alexeagle/rules_python that referenced this pull request Aug 26, 2020
Was squashed and we lost merge history
This reverts commit 0d23d57.
thundergolfer pushed a commit that referenced this pull request Aug 26, 2020
Was squashed and we lost merge history
This reverts commit 0d23d57.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0