8000 "Skylark" is an outdated name of the language, please use "starlark" … by thundergolfer · Pull Request #327 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

"Skylark" is an outdated name of the language, please use "starlark" … #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2020
Merged

"Skylark" is an outdated name of the language, please use "starlark" … #327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8516a3e
"Skylark" is an outdated name of the language, please use "starlark" …
thundergolfer-two Jun 14, 2020
d44048f
Merge branch 'master' into jonathon--buildifier-lint-skylark-name
andyscott Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion experimental/python/wheel.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def _py_package_impl(ctx):
[dep[DefaultInfo].default_runfiles.files for dep in ctx.attr.deps],
)

# TODO: '/' is wrong on windows, but the path separator is not available in skylark.
# TODO: '/' is wrong on windows, but the path separator is not available in starlark.
# Fix this once ctx.configuration has directory separator information.
packages = [p.replace(".", "/") for p in ctx.attr.packages]
if not packages:
Expand Down
0