We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This allows users to use a custom python interpreter that is built by another repository rule instead of using a pre-built interpreter binary that is checked-in.
This tangentially addresses #257 since a common setup is to use the custom built interpreter in the python toolchain.
For example, see: https://github.com/kku1993/bazel-hermetic-python
Sorry, something went wrong.
Support python interpreter target in pi 8000 p_import.
33012a3
This allows users to use a custom python interpreter that is built by another repository rule instead of using a pre-built interpreter binary that is checked-in. This tangentially addresses bazel-contrib#257 since a common setup is to use the custom built interpreter in the python toolchain. For example, see: https://github.com/kku1993/bazel-hermetic-python
Actually use interpreter path.
54d397f
This is a great feature unblocking the use of in-build Python interpreters with pip_import (they can be compiled in Bazel - with the make workaround as in @kku1993's workaround -, or a compiled interpreter can be attached with http_archive). I tested it with an in-build interpreter from http_archive and it worked.
pip_import
make
This is necessary to use any Python interpreter from toolchain (in-build ones) with pip, not just for those interpreters built in Bazel themselves.
Support python interpreter target in pip_reposi 8000 tory
766fa8b
This allows users to use an in-build python interpreter instead of a system one with pip_repository. The in-build python interpreter can be one that is used through http_archive or built by another repository rule. Port of bazel-contrib/rules_python#312 made by @kku1993.
Merge branch 'master' into kku-python-interpreter-path
465bc02
06672cd
Use upstream version of rules_python.
3670b5c
bazel-contrib/rules_python#312 has been merged.
keep file permissions when unpacking
d6bbe55
add zipextended.py to BUILD fix import path use pip internal unzip use pip internal unzip tools remove custom zipfile implementation Add documentation of community / Bazel team ownership (bazel-contrib#308) This adds a more nuanced CODEOWNERS and explains its purpose in CONTRIBUTING.md. Fixes bazel-contrib#291. point README readers to new 0.0.2 release (bazel-contrib#302) update version in version.bzl (bazel-contrib#303) Fix for when there are so many file arguments it creates the Command To Long error (bazel-contrib#320) Fix failing build on CI by specifying pip package version (bazel-contrib#329) `bazel build //...` was failing due to "googleapis-common-protos[grpc]" pip package being unavailable. It seems to be caused by latest googleapis-common-protos release. Specify googleapis-common-protos in requirements.txt to be in the previous version (1.51.0) to fix this. Fixes bazel-contrib#321. "Skylark" is an outdated name of the language, please use "starlark" instead (bazel-contrib#327) Co-authored-by: Andy Scott <andyscott@users.noreply.github.com> Support python interpreter target in pip_import. (bazel-contrib#312) * Support python interpreter target in pip_import. This allows users to use a custom python interpreter that is built by another repository rule instead of using a pre-built interpreter binary that is checked-in. This tangentially addresses bazel-contrib#257 since a common setup is to use the custom built interpreter in the python toolchain. For example, see: https://github.com/kku1993/bazel-hermetic-python * Actually 8000 use interpreter path. Co-authored-by: Andy Scott <andyscott@users.noreply.github.com> Address bazel-contrib#289 (bazel-contrib#328) Co-authored-by: Andy Scott <andyscott@users.noreply.github.com> Fix errors with incompatible_disallow_empty_glob (bazel-contrib#315) Allow py_library sources to be empty. If --incompatible_disallow_empty_glob is set then generated py_library targets will fail if there are no .py files. Examples are pymssql==2.1.4 and cx-Oracle==7.2.3. Set `allow_empty = True` for glob(). Bazel issue for incompatible_disallow_empty_glob: bazelbuild/bazel#8195 Co-authored-by: Andy Scott <andyscott@users.noreply.github.com> rebuild piptool and whltool update filename, add links to pip function definitions remove typing checks chore: github setup improvements (bazel-contrib#334) Remove mention and usage of Bazel Federation (bazel-contrib#339) It's currently a stalled project so it's not useful for us to direct new users there in our README. Separately it is harder to develop on rules_python since it is currently not self-contained. For example it's hard to find or adjust the version of rules_pkg without looking/editing in the federation repo. Tony says this is an okay change: bazelbuild/bazel-federation@63f9746#commitcomment-40577834 leaner implementation of pip unzip remove unzip.py temp test with tools 2nd test with tools final test with tools replace with master tools merge original tools feat(examples): move examples to a nested WORKSPACE (bazel-contrib#337) This lets users understand the example in isolation. They can copy/paste the example directory and it works correctly. This refactors the existing examples which are quite weak, only really demonstrating pip usage. This makes room for examples demonstrating other features (like protocol buffers) or package managers (like poetry). In a later commit I'll add bazel-integration-testing so we get a test target that confirms the examples build (including their WORKSPACE being self-contained) warn against putting .par file changes in PR. (bazel-contrib#342)
6742ef2
add zipextended.py to BUILD fix import path use pip internal unzip use pip internal unzip tools remove custom zipfile implementation Add documentation of community / Bazel team ownership (bazel-contrib#308) This adds a more nuanced CODEOWNERS and explains its purpose in CONTRIBUTING.md. Fixes bazel-contrib#291. point README readers to new 0.0.2 release (bazel-contrib#302) update version in version.bzl (bazel-contrib#303) Fix for when there are so many file arguments it creates the Command To Long error (bazel-contrib#320) Fix failing build on CI by specifying pip package version (bazel-contrib#329) `bazel build //...` was failing due to "googleapis-common-protos[grpc]" pip package being unavailable. It seems to be caused by latest googleapis-common-protos release. Specify googleapis-common-protos in requirements.txt to be in the previous version (1.51.0) to fix this. Fixes bazel-contrib#321. "Skylark" is an outdated name of the language, please use "starlark" instead (bazel-contrib#327) Co-authored-by: Andy Scott <andyscott@users.noreply.github.com> Support python interpreter target in pip_import. (bazel-contrib#312) * Support python interpreter target in pip_import. This allows users to use a custom python interpreter that is built by another repository rule instead of using a pre-built interpreter binary that is checked-in. This tangentially addresses bazel-contrib#257 since a common setup is to use the custom built interpreter in the python toolchain. For example, see: https://github.com/kku1993/bazel-hermetic-python * Actually use interpreter path. Co-authored-by: Andy Scott <andyscott@users.noreply.github.com> Address bazel-contrib#289 (bazel-contrib#328) Co-authored-by: Andy Scott <andyscott@users.noreply.github.com> Fix errors with incompatible_disallow_empty_glob (bazel-contrib#315) Allow py_library sources to be empty. If --incompatible_disallow_empty_glob is set then generated py_library targets will fail if there are no .py files. Examples are pymssql==2.1.4 and cx-Oracle==7.2.3. Set `allow_empty = True` for glob(). Bazel issue for incompatible_disallow_empty_glob: bazelbuild/bazel#8195 Co-authored-by: Andy Scott <andyscott@users.noreply.github.com> rebuild piptool and whltool update filename, add links to pip function definitions remove typing checks chore: github setup improvements (bazel-contrib#334) Remove mention and usage of Bazel Federation (bazel-contrib#339) It's currently a stalled project so it's not useful for us to direct new users there in our README. Separately it is harder to develop on rules_python since it is currently not self-contained. For example it's hard to find or adjust the version of rules_pkg without looking/editing in the federation repo. Tony says this is an okay change: bazelbuild/bazel-federation@63f9746#commitcomment-40577834 leaner implementation of pip unzip remove unzip.py temp test with tools 2nd test with tools final test with tools replace with master tools merge original tools feat(examples): move examples to a nested WORKSPACE (bazel-contrib#337) This lets users understand the example in isolation. They can copy/paste the example directory and it works correctly. This refactors the existing examples which are quite weak, only really demonstrating pip usage. This makes room for examples demonstrating other features (like protocol buffers) or package managers (like poetry). In a later commit I'll add bazel-integration-testing so we get a test target that confirms the examples build (including their WORKSPACE being self-contained) warn against putting .par file changes in PR. (bazel-contrib#342)
andyscott andyscott approved these changes
thundergolfer Awaiting requested review from thundergolfer
Successfully merging this pull request may close these issues.