10000 Add documentation of community / Bazel team ownership by brandjon · Pull Request #308 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

Add documentation of community / Bazel team ownership #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2020
Merged

Add documentation of community / Bazel team ownership #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb40a16
Add documentation of community / Bazel team ownership
brandjon May 12, 2020
31f1693
Minor wording change
brandjon May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,19 @@
* @brandjon @lberki
# NB: Last matching rule takes precedence in CODEOWNERS.

# Fall-through to community maintainers.
* @thundergolfer @andyscott

# Core Python rules belong to the Bazel team.
/python/ @brandjon @lberki
# But not everything under python/ is the core Python rules.
/python/pip.bzl @thundergolfer @andyscott
/python/whl.bzl @thundergolfer @andyscott
/python/requirements.txt @thundergolfer @andyscott

# The proposals dir corresponds to the Bazel proposals process, documented
# here: https://bazel.build/designs/index.html
/proposals/ @brandjon @lberki

# Certain repo metadata files should stay as-is, particularly these.
/LICENSE @brandjon @lberki
/CONTRIBUTING.md @brandjon @lberki
24 changes: 24 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,27 @@ pull request.

<sup>1</sup> See "[Reflections on Trusting Trust](https://en.wikipedia.org/wiki/Backdoor_(computing)#Compiler_backdoors)".

## Core rules

The bulk of this repo is owned and maintained by the Bazel Python community.
However, since the core Python rules (`py_binary` and friends) are still
bundled with Bazel itself, the Bazel team retains ownership of their stubs in
this repository. This will be the case at least until the Python rules are
fully migrated to Starlark code.

Practically, this means that a Bazel team member should approve any PR
concerning the core Python logic. This includes everything under the `python/`
directory except for `pip.bzl`, `whl.bzl`, and `requirements.txt`.

Issues should be triaged as follows:

- Anything concerning the way Bazel implements the core Python rules should be
filed under [bazelbuild/bazel](https://github.com/bazelbuild/bazel), using
the label `team-Rules-python`.

- If the issue specifically concerns the rules_python stubs, it should be filed
here in this repository and use the label `core-rules`.

- Anything else, such as feature requests not related to existing core rules
functionality, should also be filed in this repository but without the
`core-rules` label.
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ changes as they evolve. There are no guarantees for rules underneath the
`experimental/` directory.

This repository is maintained by the Bazel community. Neither Google, nor the
Bazel team provides support for the code. However, this repository is part of
Bazel team, provides support for the code. However, this repository is part of
the test suite used to vet new Bazel releases. See the [How to
contribute](CONTRIBUTING.md) page for information on our development workflow.

Expand Down
0