8000 Add information regarding support by laurentlb · Pull Request #290 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

Add information regarding support #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2020
Merged

Add information regarding support #290

merged 1 commit into from
Apr 9, 2020

Conversation

laurentlb
Copy link
Contributor

No description provided.

@keith
Copy link
Member
keith commented Apr 7, 2020

Can you clarify if Google isn't providing support here who has access to review / merge changes besides folks from Google or if the Google folks will continue to provide that role?

@thundergolfer
Copy link
thundergolfer commented Apr 7, 2020 •
edited
Loading

Can you clarify ... who has access to review / merge changes besides folks from Google

Seconded, when I read this:

This repository is maintained by the Bazel community.

A "maintainer" is to my mind someone who has reviewer and push permissions to the repo, and also participates in or owns the release process. As far as I know currently only Google employees are "maintainers" under this definition, which if true means this repository isn't really maintained by the community.

If this PR is indication that rules_python is moving to a model similar to rules_scala, where invested companies like Stripe and Wix have employees that are maintainers, that's good 🙂.

@laurentlb
Copy link
Contributor Author
laurentlb commented Apr 8, 2020 •
edited
Loading

Thanks for the feedback. My goal is indeed to move to a model like rules_scala, and change the set of maintainers.

@laurentlb laurentlb merged commit a0fbf98 into bazel-contrib:master Apr 9, 2020
@brandjon brandjon mentioned this pull request Apr 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lberki lberki lberki approved these changes

@brandjon brandjon Awaiting requested review from brandjon

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@laurentlb @keith @thundergolfer @lberki @googlebot
0