8000 Add extra_pip_args option to pip_import by scarito1 · Pull Request #274 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]

Skip to content

Add extra_pip_args option to pip_import #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

scarito1
Copy link
Contributor

Adds the attr extra_pip_args to pip_import. These args will be passed along to the pip invocation inside piptool. This enables special pip usage such as loading packages from an alternate repository or local directory.

Adds the attr extra_pip_args to pip_import.  These args will be passed
along to the pip invocation inside piptool.
Copy link
Contributor
@brandjon brandjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added a comment that the args shouldn't contain whitespace. I'll merge on my end.

@brandjon brandjon closed this in dd7f9c5 Feb 21, 2020
gergelyfabian added a commit to gergelyfabian/rules_python_external that referenced this pull request May 27, 2020
gergelyfabian added a commit to gergelyfabian/rules_python_external that referenced this pull request May 28, 2020
gergelyfabian added a commit to gergelyfabian/rules_python_external that referenced this pull request Jun 3, 2020
gergelyfabian added a commit to gergelyfabian/rules_python_external that referenced this pull request Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0