8000 Fix immutable frozen set bug in defs.bzl by jamiesnape · Pull Request #262 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

Fix immutable frozen set bug in defs.bzl #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2019
Merged

Fix immutable frozen set bug in defs.bzl #262

merged 2 commits into from
Dec 5, 2019

Conversation

jamiesnape
Copy link
Contributor
@jamiesnape jamiesnape commented Dec 3, 2019 •
edited
Loading

When adding tags to a native py_library rule that is created through a macro we
were not properly considering the case where the tags came from a different
file and therefore were frozen. This caused an error.

Analog of bazelbuild/rules_cc@cfe68f6.

@oquenchil
Fix immutable frozen set bug in defs.bzl
5d6bdad 
When adding tags to a native py_library rule that is created through a macro we
were not properly considering the case where the tags came from a different
file and therefore were frozen. This caused an error.

Analog of bazelbuild/rules_cc@cfe68f6

Co-authored-by: Googler <plf@google.com>
@jamiesnape jamiesnape mentioned this pull request Dec 3, 2019
Merged
@brandjon
Copy link
Contributor
brandjon commented Dec 5, 2019

Thanks!

@brandjon brandjon merged commit 38f86fb into bazel-contrib:master Dec 5, 2019
@jamiesnape jamiesnape deleted the fix-immutable-frozen-set-bug branch December 5, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandjon brandjon brandjon approved these changes

@lberki lberki Awaiting requested review from lberki

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamiesnape @brandjon @googlebot
0