10000 Fix WORKSPACE/distro boilerplate by brandjon · Pull Request #238 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

Fix WORKSPACE/distro boilerplate #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2019
Merged

Fix WORKSPACE/distro boilerplate #238

merged 1 commit into from
Oct 9, 2019

Conversation

brandjon
Copy link
Contributor
@brandjon brandjon commented Oct 9, 2019

We don't have a toolchain method, so don't try to call one in WORKSPACE. Add
optional pip_repositories() call to README and add note that relnotes need
manual editing for this.

+aiuto FYI but force-submitting.

@brandjon
Fix WORKSPACE/distro boilerplate
469ef8a 
We don't have a toolchain method, so don't try to call one in WORKSPACE. Add
optional pip_repositories() call to README and add note that relnotes need
manual editing for this.
@brandjon brandjon requested a review from aiuto October 9, 2019 04:50
@brandjon brandjon requested a review from lberki as a code owner October 9, 2019 04:50
@brandjon brandjon removed the request for review from lberki October 9, 2019 04:50
@brandjon brandjon merged commit 5aa465d into bazel-contrib:master Oct 9, 2019
@brandjon brandjon deleted the fixboilerplate branch October 9, 2019 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiuto aiuto Awaiting requested review from aiuto

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandjon @googlebot
0