Refactor update_tools.sh workflow and regenerate par files #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FTR that's associated with bumping the bazel version to 0.28. |
4289c07 to
8983ff3
Compare
This reorganizes and comments some package dependencies in the Dockerfile. It also regenerates the par files, so that we're now using pars based on the current version of Bazel. Fixes bazel-contrib#208.
c-parsons
approved these changes
Jul 25, 2019
fweikert
pushed a commit
to fweikert/rules_python
that referenced
this pull request
Aug 7, 2019
…trib#209) This reorganizes and comments some package dependencies in the Dockerfile. It also regenerates the par files, so that we're now using pars based on the current version of Bazel. Fixes bazel-contrib#208.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a (not yet pushed) fix for #208, and reran
update_tools.shin the docker container. This PR is to verify these files in CI.Point of order: Do we even have integration tests for the precompiled par files, or only of the source code? Must look into that. We can also test other projects manually against this commit.
The regenerated
piptool.parandwhltool.parfiles grew by 9731 bytes and 9733 bytes respectively, relative to a total filesize of 5.7 MB and 1.4 MB respectively. The similar increases suggests that the growth is due to changes in common tooling (i.e. subpar), and is any case not in and of itself problematic.Assuming these files are good, I'll merge the fix for #208 and then update this PR.