8000 cleanup(tests): Use new APIs in rules_testing 0.4.0 by rickeylev · Pull Request #1307 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content
< 8000 div class="clearfix new-discussion-timeline js-check-all-container container-xl px-3 px-md-4 px-lg-5 mt-4" data-pjax="" data-turbo-frame="">

cleanup(tests): Use new APIs in rules_testing 0.4.0 #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2023
Merged

cleanup(tests): Use new APIs in rules_testing 0.4.0 #1307

merged 1 commit into from
Jul 11, 2023

Conversation

rickeylev
Copy link
Collaborator
  • Use public APIs for DictSubject and StrSubject.
  • Use rules_testing's StructSubject instead of our own.

Work towards 1297

@rickeylev
cleanup(tests): Use new APIs in rules_testing 0.4.0
25a7ee4 
* Use public APIs for DictSubject and StrSubject.
* Use rules_testing's StructSubject instead of our own.

Work towards 1297
8000
@rickeylev rickeylev requested a review from chrislovecnm July 11, 2023 16:54
chrislovecnm
chrislovecnm approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor
@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrislovecnm chrislovecnm enabled auto-merge July 11, 2023 17:15
@chrislovecnm chrislovecnm added this pull request to the merge queue Jul 11, 2023
Merged via the queue into bazel-contrib:main with commit 02b521f Jul 11, 2023
@rickeylev rickeylev deleted the rules_testing.cleanup branch July 11, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickeylev @chrislovecnm
0