8000 Selecting Between Python 2 and 3 by brandjon · Pull Request #127 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

Selecting Between Python 2 and 3 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 2, 2018
Merged

Selecting Between Python 2 and 3 #127

merged 6 commits into from
Nov 2, 2018

Conversation

brandjon
Copy link
Contributor
@brandjon brandjon commented Nov 2, 2018

Reviewer TBD. This design impacts native behavior so it'll also be indexed on bazelbuild/proposals and subject to Bazel design review.

@brandjon brandjon self-assigned this Nov 2, 2018
aiuto
aiuto reviewed Nov 2, 2018
View reviewed changes
aiuto
aiuto reviewed Nov 2, 2018
View reviewed changes
aiuto
aiuto approved these changes Nov 2, 2018
View reviewed changes
Copy link
@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions. Feel free to use or not.

@brandjon brandjon merged commit e2f22d5 into master Nov 2, 2018
@brandjon brandjon deleted the proposal-2-3-support branch November 2, 2018 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiuto aiuto aiuto approved these changes

Assignees

@brandjon brandjon

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandjon @aiuto @googlebot
0