8000 runfiles: Add proper test coverage for an edge case by fmeum · Pull Request #1012 · bazel-contrib/rules_python · GitHub
[go: up one dir, main page]
Skip to content

runfiles: Add proper test coverage for an edge case #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2023
Merged

runfiles: Add proper test coverage for an edge case #1012

merged 1 commit into from
Jan 25, 2023

Conversation

fmeum
Copy link
Member
@fmeum fmeum commented Jan 25, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The repo mapping wasn't set up correctly to actually test that root symlinks aren't subject to repo mapping.

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@fmeum fmeum requested a review from rickeylev as a code owner January 25, 2023 11:51
@fmeum
Copy link
Member Author
fmeum commented Jan 25, 2023

CC @alexeagle

@fmeum
runfiles: Add proper test coverage for an edge case
3a0afb5 
The repo mapping wasn't set up correctly to actually test that root
symlinks aren't subject to repo mapping.
@fmeum fmeum force-pushed the test-runfiles-edge-case branch from 400fd2b to 3a0afb5 Compare January 25, 2023 11:54
@alexeagle alexeagle merged commit da106c5 into bazel-contrib:main Jan 25, 2023
@fmeum fmeum deleted the test-runfiles-edge-case branch January 25, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmeum @alexeagle
0