Add support for per-environment settings #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for per-environment settings in Bashly, allowing users to specify environment-specific configuration values by appending _production or _development suffixes to option names in the settings file.
- Refactored the settings retrieval logic to support environment-specific configuration overrides
- Added comprehensive test coverage for the new environment suffix functionality
- Updated documentation in the settings file to explain the new feature
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lib/bashly/settings.rb |
Refactored settings retrieval logic to support environment-specific overrides with _production/_development suffixes |
spec/bashly/settings_spec.rb |
Added test cases to verify environment suffix override behavior |
lib/bashly/libraries/settings/settings.yml |
Enhanced documentation with detailed explanation of environment overrides feature |
.rubocop.yml |
Added exception for longer test examples in command spec file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to c
6CC5
omment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #665 and raised in #664.
This adds the ability to add
_productionor_developmentsuffix to all option names in the settings.