E52B Replace `picocolors` with `node:util.styleText()` in `@babel/code-frame` by fisker · Pull Request #17678 · babel/babel · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@fisker
Copy link
Contributor
@fisker fisker commented Dec 21, 2025
Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT
  1. Do we want support for colors in the browser?
  2. We'll need another entry for browser, since styleText is available in browser, how do we process?

Fixes #16945
Closes #14555

Copy link
Member
@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine if we make it so in the browser it throws when trying to force colors.

@fisker
Copy link
Contributor Author
fisker commented Jan 9, 2026
  1. Use export condition? Do we support bundling two different files?
  2. We should also drop js-tokens in browser, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide "browser" entry for @babel/code-frame package

2 participants

0