[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose a 0-copy interface for serializing/deseralizing the filters directly #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose a 0-copy interface for serializing/deseralizing the filters directly #80

wants to merge 1 commit into from

Conversation

vlovich
Copy link
Contributor
@vlovich vlovich commented Nov 3, 2023

Initial implementation as described in the RFC at #79

@vlovich vlovich force-pushed the 0-copy-serde branch 2 times, most recently from c03955b to 6a42927 Compare November 3, 2023 00:53
vlovich
vlovich commented Nov 3, 2023
View reviewed changes
src/bfuse32.rs
segment_length_mask: u32,
segment_count_length: u32,
#[cfg_attr(feature = "serde", serde(flatten))]
descriptor: Descriptor,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is technically a breaking change in bincode serialization/deserialization? Might have to flatten it back to what it was but let me know.

@vlovich vlovich force-pushed the 0-copy-serde branch 2 times, most recently from ccf201c to 1b68531 Compare November 3, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vlovich