set events on browser back, history.back() - refactored for new layout #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this error occur in all browsers? Safari, Firefox, and Chrome? |
|
Tested so far:
I haven't used all components(which needs script event inits), it seems that all need "popstate" event registration. Your components have a neat internal structure, I like it. While thinking about it, not to pollute this PR, I created discussion #175. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using htmx-swap, after a
history.back()action, drawer trigger button is not initialized. This PR is to init events onpopstateevent.Note: I had to close previous PR #162 and open this because of layout change.