fix(idempotency): include sk in error msgs when using composite key #6325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6325 +/- ##
========================================
Coverage 96.31% 96.31%
========================================
Files 242 242
Lines 11706 11710 +4
Branches 870 871 +1
========================================
+ Hits 11275 11279 +4
Misses 337 337
Partials 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
<
8000
/div>
dreamorosi
approved these changes
Mar 24, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #6308
Summary
Changes
This PR updates the
DataRecordclass so that it optionally accepts asort_key_attrparameter. This parameter is provided only when using theDynamoDBPersistenceLayerand when using a composite key (pk + sk).This fixes a bug that prevented the
IdempotencyAlreadyInProgressErrorfrom constructing the appropriate error message. The error now include both keys in the error message, making it easier for customers to detect idempotent requests or troubleshoot issues.User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.