fix(parser): remove 'aws:' prefix from SelfManagedKafka model #5584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5584 +/- ##
========================================
Coverage 96.16% 96.16%
========================================
Files 229 229
Lines 10836 10836
Branches 2015 2015
========================================
Hits 10420 10420
Misses 327 327
Partials 89 89 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
leandrodamascena
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Thanks a lot for sending this PR @anafalcao! Great work!! 🚀
APPROVED!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#5559
Summary
Changes
The eventSource for self-managed Apache Kafka is not "eventSource": "aws:SelfManagedKafka" as we are currently using. It should be "eventSource": "SelfManagedKafka" as documented in the oficial Developer Guide https://docs.aws.amazon.com/lambda/latest/dg/with-kafka.html
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.